Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gRPC trailers only response #1209

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fix gRPC trailers only response #1209

merged 1 commit into from
Sep 4, 2024

Conversation

srikrsna-buf
Copy link
Member

@srikrsna-buf srikrsna-buf commented Sep 4, 2024 •
edited
Loading

Fix gRPC trailers only response. Conformance test v1.0.3 include test cases for this. Upgrade PR: #1208. Closes #1161

@srikrsna-buf
Fix gRPC trailers only response
2b3b49d 
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
timostamm
timostamm approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

IMO this does fix #1161 and should be called out here, even though it was reported for v2. Once we merge this fix into v2 and release, we can update the issue.

@srikrsna-buf srikrsna-buf merged commit 8eee2fa into main Sep 4, 2024
50 checks passed
@srikrsna-buf srikrsna-buf deleted the sk/trailers_only branch September 4, 2024 18:15
@timostamm timostamm mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timostamm timostamm timostamm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V2: gRPC error code's no longer present in thrown ConnectError
2 participants
@srikrsna-buf @timostamm